-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Quest Lab Hub module support #6941
feat: Quest Lab Hub module support #6941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juggernautsei Only major problem I see is that LabTransmitEvent appears to have not been checked in. Everything else looks ok. Is there a test environment that people can use to test this code out? I looked through the gen_hl7_order_inc.php but I don't see anyway to test if its working correctly w/o a test bed environment so I have to assume its just working correctly.
Once the LabTransmitEvent is checked in and reviewed we can probably go ahead and bring this in. We'll want to merge it into the release branch once this is in.
@adunsulag dc35d47 |
@juggernautsei I noted two items that need to be addressed in the LabTransmitEvent. One for sure is the code licensing in the documentation, the other is clarification on the input parameter. That is what I meant by taking care of those review items. |
@adunsulag I have addressed the input parameters above. Here is the license change. |
Once CI engine finishes, should be able to bring this in. Thanks @juggernautsei. |
Thank you Sherwin for listening to my concerns. |
* Quest Lab Hub module support * PSR fixes * fix dependency * LabTransportEvent * License change * Event specified as Quest
I just brought this into the rel-702 branch |
Fixes #6940
Short description of what this resolves:
Changes proposed in this pull request: