Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Quest Lab Hub module support #6941

Merged

Conversation

juggernautsei
Copy link
Member

Fixes #6940

Short description of what this resolves:

Changes proposed in this pull request:

Copy link
Sponsor Member

@adunsulag adunsulag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juggernautsei Only major problem I see is that LabTransmitEvent appears to have not been checked in. Everything else looks ok. Is there a test environment that people can use to test this code out? I looked through the gen_hl7_order_inc.php but I don't see anyway to test if its working correctly w/o a test bed environment so I have to assume its just working correctly.

Once the LabTransmitEvent is checked in and reviewed we can probably go ahead and bring this in. We'll want to merge it into the release branch once this is in.

interface/forms/procedure_order/common.php Show resolved Hide resolved
interface/forms/procedure_order/common.php Outdated Show resolved Hide resolved
src/Events/Services/LabTransmitEvent.php Outdated Show resolved Hide resolved
src/Events/Services/LabTransmitEvent.php Outdated Show resolved Hide resolved
src/Events/Services/LabTransmitEvent.php Outdated Show resolved Hide resolved
@adunsulag adunsulag added this to the 7.0.2 milestone Nov 8, 2023
@juggernautsei
Copy link
Member Author

@adunsulag dc35d47
LabTransmitEvent was uploaded yesterday. Dr. Alex Berlin is doing production testing now. Once we have a satisfactory run. Quest will approve Go Live.

@adunsulag
Copy link
Sponsor Member

@juggernautsei I noted two items that need to be addressed in the LabTransmitEvent. One for sure is the code licensing in the documentation, the other is clarification on the input parameter. That is what I meant by taking care of those review items.

@juggernautsei
Copy link
Member Author

@adunsulag I have addressed the input parameters above. Here is the license change.

@adunsulag
Copy link
Sponsor Member

Once CI engine finishes, should be able to bring this in. Thanks @juggernautsei.

@sjpadgett
Copy link
Sponsor Member

Thank you Sherwin for listening to my concerns.

@adunsulag adunsulag merged commit e308310 into openemr:master Nov 8, 2023
20 checks passed
bradymiller pushed a commit that referenced this pull request Nov 9, 2023
* Quest Lab Hub module support

* PSR fixes

* fix dependency

* LabTransportEvent

* License change

* Event specified as Quest
@bradymiller
Copy link
Sponsor Member

I just brought this into the rel-702 branch
(plan to bring in commits from master to rel-702 quickly (and in order of master) prior to release to avoid missing anything and avoiding merging issues)

@juggernautsei juggernautsei deleted the quest-lab-hub-support-module branch November 9, 2023 10:01
@adunsulag adunsulag changed the title Quest Lab Hub module support feat: Quest Lab Hub module support Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It would be nice to have a module to connect Quest
4 participants